Remove nn package.#107
Merged
Merged
Conversation
- Move ActivationFunctions to core - Examples are already in deepwit - Move optimziers to optimizer package
| ) | ||
|
|
||
| lazy val nn = (project in file("nn")) | ||
| lazy val optimizer = (project in file("optimizer")) |
Contributor
There was a problem hiding this comment.
Not sure if we need to make optimizer a separate module? Why not have it as a core dimwit package similar to how distributions are integrated? We require a separate import but the whenever dimwit is imported as a library optimizers come with it?
Collaborator
Author
There was a problem hiding this comment.
Agree. I did the same for the ActivationFunctions. I will make a commit moving optimizers to core.
Collaborator
Author
There was a problem hiding this comment.
optimizer moved to core in last commit.
Collaborator
Author
|
This PR also removes most of the examples. Do the examples make sense as-is with LR and VAE? Both examples are self-contained, using only dimwit core stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marcelluethi Let's see this as a first suggestion on how we could remove the nn package. Please suggest improvements :)